search

kanidm / webauthn-rs

An implementation of webauthn components for Rustlang servers
Mozilla Public License 2.0
485 stars 80 forks source link

Re-enable clippy in CI for stable once clap issues addressed. #313

Closed micolous closed 1 year ago

micolous commented 1 year ago

https://github.com/kanidm/webauthn-rs/pull/312 temporarily disabled Clippy in CI for 1.69 due to spuriously-failing clap correctness checks: https://github.com/rust-lang/rust-clippy/issues/10421

We'll need to revert that at some point once the upstream issue is fixed in a stable release.

There's an existing request to cherry-pick the fix in https://github.com/rust-lang/rust-clippy/issues/10685

micolous commented 1 year ago

It looks like clap 3.2.24 just disabled the correctness lints in the macros, which I think should let users explicitly disable those checks... which means we'll have a bunch of clippy allow rules for clap.

clap 4.2.x looks like it doesn't have the same issue, so migrating to that may be the easier way to address this. I've started on this in #315.