kanidm / webauthn-rs

An implementation of webauthn components for Rustlang servers
Mozilla Public License 2.0
483 stars 80 forks source link

OpenSSL dependency update to support v3.x #340

Closed yaleman closed 1 year ago

yaleman commented 1 year ago

Fixes #339

dmulder commented 1 year ago

I just tried building your branch on my machine with openSSL 3.1.2 and it still fails with the exact same error:

error[E0599]: no associated item named `NO_CHECK_TIME` found for struct `X509VerifyFlags` in the current scope
    --> webauthn-rs-core/src/attestation.rs:1279:49
     |
1279 |             .set_flags(verify::X509VerifyFlags::NO_CHECK_TIME)
     |                                                 ^^^^^^^^^^^^^
     |                                                 |
     |                                                 associated item not found in `X509VerifyFlags`
     |                                                 help: there is an associated constant with a similar name: `USE_CHECK_TIME`
Firstyear commented 1 year ago
libopenssl-devel-3.1.2-1.1.noarch

Seems to be working on my tumbleweed machine? Also confirmed it works on my mac with 3.1.2 as well.

Do you potentially have a second openldap/libressl present?

dmulder commented 1 year ago

Do you potentially have a second openldap/libressl present?

Yes, I have libressl.

Firstyear commented 1 year ago

Ahh that'll be it. libressl is broken wrt to openssl-rs normally, so it's likely a missing feature/flag/const in libressl.

yaleman commented 1 year ago

@micolous I've reverted what fmt changes I can and I don't have enough git-foo to convince the others to calm themselves, I hope that's OK.

micolous commented 1 year ago

Thanks! CI failures on MSRV look like a separate issue not triggered by this change, I've opened https://github.com/kanidm/webauthn-rs/issues/346 about this.