search

kanidm / webauthn-rs

An implementation of webauthn components for Rustlang servers
Mozilla Public License 2.0
490 stars 80 forks source link

Fix builds on MSRV (1.67.0) or bump MSRV #346

Closed micolous closed 1 year ago

micolous commented 1 year ago

Builds on the MSRV (1.67.0) appear to be failing this week:

https://github.com/kanidm/webauthn-rs/actions/runs/5993898551/job/16254812814#step:11:79

 error: package `anstream v0.5.0` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.70.0 or newer, or use
cargo update -p anstream@0.5.0 --precise ver
where `ver` is the latest version of `anstream` supporting rustc 1.67.0
Error: Process completed with exit code 101.

https://github.com/kanidm/webauthn-rs/actions/runs/6007681904/job/16294175785?pr=340#step:7:442

 error: package `clap_lex v0.5.1` cannot be built because it requires rustc 1.70.0 or newer, while the currently active rustc version is 1.67.0
Either upgrade to rustc 1.70.0 or newer, or use
cargo update -p clap_lex@0.5.1 --precise ver
where `ver` is the latest version of `clap_lex` supporting rustc 1.67.0
Error: Process completed with exit code 101.

We should figure out a way to fix the build, or bump the MSRV to match.

Firstyear commented 1 year ago

Bump it. Rust community tends to be very okay with higher MSRV, and current 0.5.0 is still dev anyway.