search

kanidm / webauthn-rs

An implementation of webauthn components for Rustlang servers
Mozilla Public License 2.0
464 stars 79 forks source link

webauthn-rs command line #414

Closed arthurgleckler closed 3 months ago

arthurgleckler commented 6 months ago

Fixes # This pull request implements a new feature, not a fix.

This pull request implements the basic webauthn-rs command line that I mentioned in the discussion of issue #397. The idea is that this wrapper can be used for debugging and experimentation. It can also be used to implement webauthn in programming languages other than Rust. This is simplified by passing JSON to and from the command-line process rather than using a foreign function interface.

If you run make under tutorial/server/cli/, you'll see the result of running the command line for the two steps of passkey registration and the two steps of authentication. It's modeled after the tutorial/server/tide/ example.

Using this wrapper, I've implemented, in some code that is still private, a webauthn registration and login system in the programming language Scheme, with a Javascript front end. I've tested it with both a Yubikey 5C key and a Pixel phone passkey.

I've included minimal documentation in the comments, but I'm happy to add more if you think this pull request is a good idea.

Thank you very much for making webauthn-rs available. Without it, implementing webauthn for a Scheme front end would have been vastly more work.

Firstyear commented 6 months ago

@micolous If you have some item to review as well, that'd be great.

arthurgleckler commented 6 months ago

Okay, I've run rust fmt. Sorry, I'm a novice Rustacean.

Firstyear commented 6 months ago

Its okay, that's what the checks are for. You've done pretty well for a first time :)

arthurgleckler commented 5 months ago

Please let me know if there's anything else I should do. Thanks.

Firstyear commented 5 months ago

Please let me know if there's anything else I should do. Thanks.

@micolous has just been really busy is all :) I'll ask him again to have a look.

arthurgleckler commented 3 months ago

Just pinging again. I'd love to write about this on my blog. I'm sure that there are other people who could make use of this. Perhaps I'm flattering myself, but I think a JSON-based API like this with your excellent underlying Rust implementation could allow other programming languages to implement Webauthn more quickly. Webauthn adoption isn't moving as quickly as it should.

Thanks, and sorry if I'm being a pest. I know that everyone's busy.

Firstyear commented 3 months ago

Oh I'm so sorry this fell by the wayside!

arthurgleckler commented 3 months ago

I believe that I've incorporated all of your suggestions. Would you please take a look when you have a chance?

Thanks.

arthurgleckler commented 3 months ago

Now that a506d89 is committed, I've rebased and force-pushed onto that. I don't know whether that will fix the PR run failure I received email about.

Firstyear commented 3 months ago

I restarted the CI to check :)

arthurgleckler commented 3 months ago

It failed again, but the underlying error appears to be "error: package bumpalo v3.15.4 cannot be built because it requires rustc 1.73.0 or newer, while the currently active rustc version is 1.70.0". I'm not using bumpalo, at least not directly. Can you think of any reason this would fail?

Oh, I see that it's failing on master, too:

https://github.com/kanidm/webauthn-rs/commits/master/

arthurgleckler commented 3 months ago

Otherwise things look good now, thanks for sticking with this. 😄

I'm thrilled! Thanks.

Firstyear commented 2 months ago

@arthurgleckler This has now been released on crates.io. Thank you!