search

kanishka-linux / kawaii-player

Multimedia player, media library manager and portable media server with PC-To-PC casting feature.
GNU General Public License v3.0
617 stars 44 forks source link

Removing unnecessary if statement from NetWorkManager.interceptRequest #1

Closed Alir3z4 closed 7 years ago

Alir3z4 commented 7 years ago

"block" is already has a value

kanishka-linux commented 7 years ago

If 'if block', statement is removed then info.block(block) statement will be executed for every url which will go through the network, which will be costly compared to blocking it with simple if statement beforehand. And moreover I think, if statement improves readability of the code.

Alir3z4 commented 7 years ago

Oh, that's true. Ignore my pull request then