search

kanisterio / kanister

An extensible framework for application-level data management on Kubernetes
https://kanister.io
Apache License 2.0
760 stars 155 forks source link

[BUG] BlockStorageProviderSuite not run #2043

Closed leuyentran closed 1 year ago

leuyentran commented 1 year ago

Describe the bug Due to lack of env config, tests in BlockStorageProviderSuite are not run by make test. These tests cover important storage operations such as CreateVolume or SnapshotCopy, and therefore should run on a regular basis.

On another note, these tests make call to external providers and should likely be placed in an integration pipeline and not unit tests.

To Reproduce Steps to reproduce the behavior:

  1. Run make test
  2. Observe that 
    === RUN   Test
SKIP: blockstorage_test.go:103: BlockStorageProviderSuite.TestCreateSnapshot
SKIP: blockstorage_test.go:77: BlockStorageProviderSuite.TestCreateVolume
SKIP: blockstorage_test.go:311: BlockStorageProviderSuite.TestFilterSnasphotWithTags
SKIP: blockstorage_test.go:146: BlockStorageProviderSuite.TestSnapshotCopy
SKIP: blockstorage_test.go:209: BlockStorageProviderSuite.TestSnapshotsList
SKIP: blockstorage_test.go:103: BlockStorageProviderSuite.TestCreateSnapshot
SKIP: blockstorage_test.go:77: BlockStorageProviderSuite.TestCreateVolume
SKIP: blockstorage_test.go:311: BlockStorageProviderSuite.TestFilterSnasphotWithTags
SKIP: blockstorage_test.go:146: BlockStorageProviderSuite.TestSnapshotCopy
SKIP: blockstorage_test.go:209: BlockStorageProviderSuite.TestSnapshotsList
SKIP: blockstorage_test.go:103: BlockStorageProviderSuite.TestCreateSnapshot
SKIP: blockstorage_test.go:77: BlockStorageProviderSuite.TestCreateVolume
SKIP: blockstorage_test.go:311: BlockStorageProviderSuite.TestFilterSnasphotWithTags
SKIP: blockstorage_test.go:146: BlockStorageProviderSuite.TestSnapshotCopy
SKIP: blockstorage_test.go:209: BlockStorageProviderSuite.TestSnapshotsList
SKIP: blockstorage_test.go:103: BlockStorageProviderSuite.TestCreateSnapshot
SKIP: blockstorage_test.go:77: BlockStorageProviderSuite.TestCreateVolume
SKIP: blockstorage_test.go:311: BlockStorageProviderSuite.TestFilterSnasphotWithTags
SKIP: blockstorage_test.go:146: BlockStorageProviderSuite.TestSnapshotCopy
SKIP: blockstorage_test.go:209: BlockStorageProviderSuite.TestSnapshotsList
OK: 0 passed, 20 skipped
--- PASS: Test (0.00s)
PASS
ok      github.com/kanisterio/kanister/pkg/blockstorage 0.044s
=== RUN   Test
SKIP: <autogenerated>:1: AWSEBSSuite.TestGetRegions (Test AWSEBSSuite.TestGetRegions requires the environemnt variable 'AWS_ACCESS_KEY_ID')
PASS: <autogenerated>:1: AWSEBSSuite.TestVolumeParse    0.000s
PASS: <autogenerated>:1: ZoneSuite.TestZoneWithUnknownNodeZones 0.000s
OK: 2 passed, 1 skipped
--- PASS: Test (0.00s)
PASS
ok      github.com/kanisterio/kanister/pkg/blockstorage/awsebs  0.040s

Expected behavior

  1. At minimum, tests run on a regular basis
  2. Preferably, tests run an an integration pipeline of some sort
github-actions[bot] commented 1 year ago

Thanks for opening this issue :+1:. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

github-actions[bot] commented 1 year ago

This issue is marked as stale due to inactivity. Add a new comment to reactivate it.

github-actions[bot] commented 1 year ago

This issue is closed due to inactivity. Feel free to reopen it, if it's still relevant.