search

kanisterio / kanister

An extensible framework for application-level data management on Kubernetes
https://kanister.io
Apache License 2.0
764 stars 155 forks source link

Allow imagePullSecrets configurable on operator Deployment #2999

Open ifalex opened 4 months ago

ifalex commented 4 months ago

Is your feature request related to a problem? Please describe. Deployment for kanister-operator is quite limited in options, therefore it fails under many kube-score/kube-linter tests. Allowing more options to the deployment file would benefit from robustness perspective and best practices around helm chart creation. To list a few:

Describe the solution you'd like Improve Deployment/Helm chart to make kanister-operator helm chart a more production ready option (currently won't work on Openshift for example)

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Environment Kubernetes Version/Provider: ... Storage Provider: ... Cluster Size (#nodes): ... Data Size: ...

Additional context Add any other context or screenshots about the feature request here.

github-actions[bot] commented 4 months ago

Thanks for opening this issue :+1:. The team will review it shortly.

If this is a bug report, make sure to include clear instructions how on to reproduce the problem with minimal reproducible examples, where possible. If this is a security report, please review our security policy as outlined in SECURITY.md.

If you haven't already, please take a moment to review our project's Code of Conduct document.

hairyhum commented 3 months ago

Hi @ifalex, thanks for posting that. Can you please clarify if you're not able to use kanister without these? Do you have a workaround? If not, please let us know.

ifalex commented 3 months ago

Hi @hairyhum. There are some scenarios where you want to use imagePullSecrets for air gap environments with private registry and authentication. Also this is a best practice in ecosystem so allowing this setting could improve the value of the chart delivered. There's no workaround unfortunately, had to fork the repo and patch on it.

hairyhum commented 3 months ago

Can you please share your changes and/or tests you use?

ifalex commented 3 months ago

Sure. Will do.