Another nil check fix in BlockStorageProviderSuite - Githubissues

kanisterio / kanister

An extensible framework for application-level data management on Kubernetes

https://kanister.io

Apache License 2.0

764 stars 155 forks source link

Another nil check fix in BlockStorageProviderSuite #3160

Closed pavannd1 closed 2 months ago

pavannd1 commented 2 months ago

Change Overview

The check.v1 refactor PR introduced a test bug by changing the expected result here. Similar to #3159

I explored the entire PR. This is the last one that requires a fix but I could be wrong.

Pull request type

Please check the type of change your PR introduces:

[ ] :construction: Work in Progress
[ ] :rainbow: Refactoring (no functional changes, no api changes)
[ ] :hamster: Trivial/Minor
[x] :bug: Bugfix
[ ] :sunflower: Feature
[ ] :world_map: Documentation
[ ] :robot: Test
[ ] :building_construction: Build

Issues

fixes #issue-number

Test Plan

[ ] :muscle: Manual
[ ] :zap: Unit test
[ ] :green_heart: E2E

julio-lopez commented 2 months ago

Thanks @pavannd1 🥇