search

kannagi0303 / yt-dlp-gui

Windows GUI for yt-dlp
MIT License
1.25k stars 81 forks source link

Fixing decimal.TryParse issue #129

Open amaillo-coop opened 6 months ago

amaillo-coop commented 6 months ago

GUI crash almost at finish download because Util.Tools.SecToStr() throw exception due to a Main.GetStatus() wrong decimal.TryParse() interpretation of a decimal number because my OS culture (es-ES) uses comma as decimal separator instead of a dot and yt-dlp std output is always showing decimal numbers with en-US number fomatting.

Fixing it's really simple, just force culture to "en-US" in every decimal.TryParse() on Main.GetStatus(): image

I can send you a PR with this fix, just text me.

Hope this could help. Best regards!

jeroenwalter commented 2 months ago

I had the same problem, made a pull request #147, but I only fixed the last 2 TryParse statements, I forgot the other ones in my sleep deprived state when I fixed it.... Will do so and amend the pull request tonight or tomorrow.

jeroenwalter commented 2 months ago

And done..... :)