kannagi0303 / yt-dlp-gui

Windows GUI for yt-dlp
MIT License
1.41k stars 97 forks source link

Temp files #84

Open TheGhost78 opened 1 year ago

TheGhost78 commented 1 year ago

v2023.03.20 The Temporary Folder location no longer works - the temp files go to the download target location.

kannagi0303 commented 1 year ago

Options > Temporary folder

Try to change this setting item, For this major update, most of the caching work will be handed over to yt-dlp for processing.

TheGhost78 commented 1 year ago

The temp files go to the download target location regardless of the setting in the program. The attachment was a JSON file but you can't upload those filetypes here, so I put it into a text file. This was saved within a folder called "youtube-nsig" in the temporary folder location that I had set. 59acb1f3.txt

kannagi0303 commented 1 year ago

As the GUI's main job is simply passing parameters to yt-dlp, I used the --paths temp:(path) and --cache-dir (path) paramaters. I haven't found any other paramater that can control the temporary location. If you have the correct parameters, please provide them to me.

However, if you are still not satisfied with how yt-dlp works, I can let it store all the files in the temp folder first, and then move them to the correct destination folder using the GUI.

As for the extra files generated during yt-dlp's operation, the GUI may be able to help with some of the cleaning.

TheGhost78 commented 1 year ago

I’m not quite sure what you’re saying here. The Temporary folder location setting worked perfectly in the 2023.03.08 version of the program but no longer works at all in the 2023.03.20 version. Also, the program did not create a new folder and add a JSON file into it in whichever location you set for the Temporary folder - but the 2023.03.20 version does. The JSON file that it creates mentions the 2023.03.04 version of the program.

kannagi0303 commented 1 year ago

As mentioned in my previous README, there are significant changes in the new version.

In versions prior to 2023.03.20, I only allowed yt-dlp to perform certain tasks such as retrieving information and downloading, while the GUI took over the subsequent file processing (such as merging or embedding subtitles). This allowed me to freely decide where to store the temporary data.

However, this approach limited many of the original functions and created significant obstacles for future planned implementations. Therefore, I redesigned the 2023.03.20 version to handle all downloading, merging, and conversion steps within yt-dlp.

Regarding the generation of JSON files, my GUI does not generate any, and I am not familiar with this aspect. Based on the file naming conventions and locations, I believe this is generated by yt-dlp, and a command may be needed to prevent its generation.

In my personal environment, JSON files are not generated every time, although I found some files that were generated in the past on my disk. However, I have tried several times and still do not know which command causes JSON to be generated. I need to reproduce this problem to avoid it.

TheGhost78 commented 1 year ago

v2023.03.21 If I set the Temporary folder to System (%TEMP%), it does put the temp files in that folder. If I set the Temporary folder location manually (e.g. to X:\DL) then it actually puts them in the download target location.

TheGhost78 commented 1 year ago

Actually, it seems to be a bit hit and miss where the temp files go - the target download folder still had some temp files with larger videos.

kannagi0303 commented 1 year ago

Actually, As I have been replying to you all along. The decision-making power for all temporary files lies with yt-dlp, not with yt-dlp-gui. If you have better yt-dlp parameters to provide me with, I would be happy to use them.