search

kannibalox / pyrosimple

An overhauled fork of the pyrocore tools for rTorrent
https://kannibalox.github.io/pyrosimple/
GNU General Public License v3.0
48 stars 5 forks source link

metafile.add_fast_resume() & metafile.hash_check() don't handle single file torrents the same way #24

Closed master-hax closed 1 year ago

master-hax commented 1 year ago

metafile.add_fast_resume() appends the torrent name to the downloads directory before running

however metafile.hash_check() does not do the same step

so i believe for single file torrents, a datapath that fails the hash check can still succeed for the fast resume which seems like inconsistent behavior.

kannibalox commented 1 year ago

Hm, good point. Appending the name seems a little magical for a utility class, but I don't think there's any downsides to it (callers can always check if it's a directory on their own if they want to), so I'll make hash_check() do the same.

master-hax commented 1 year ago

thanks for the fast response 🙂