search

kanryu / quickviewer

A image/comic viewer application for Windows, Mac and Linux, it can show images very fast
https://kanryu.github.io/quickviewer/
GNU General Public License v3.0
536 stars 63 forks source link

Potential License Issue #110

Closed kah0922 closed 4 years ago

kah0922 commented 5 years ago

ResizeHalf has no license file included in the repository. As explained by this link, this means the software is not opensource and, if I understand this correctly, the creator could file a take down.

To avoid this from happening, either remove ResizeHalf from quickviewer, or ask the creator to license it under a GPL-3.0 compatible license.

The package maintainer for quickviewer on the AUR explains this issue here.

On another note, for package maintainers it would be nice if unrar was an optional dependency, as it is not free software. Perhaps just using 7zip to open the rar files would work?

kanryu commented 5 years ago

@kah0922 You noticed well :)

ResizeHalf is a library that I personally requested @chikuzen to display huge images faster. Therefore, as long as it is used as a part of QuickViewer, there is no problem with licensing. I told him this problem.

The package maintainer for quickviewer on the AUR explains this issue here.

Who is the package maintainer of AUR? I do not know.

As you know, unrar has a special license. In other words, although the source code can be used as it is for the purpose of expanding the rar archive, a commercial license agreement is required for the purpose of generating one. As QuickViewer is obviously used only for the purpose of expanding, the problem of unrar does not occur.

kanryu commented 5 years ago

Perhaps just using 7zip to open the rar files would work?

Because 7zip uses unrar internally, it is not a fundamental solution. However, they seem to realize the option of rar function independently. (It may only be used for the purpose of disabling it)

kanryu commented 4 years ago

I made it.