search

kanryu / quickviewer

A image/comic viewer application for Windows, Mac and Linux, it can show images very fast
https://kanryu.github.io/quickviewer/
GNU General Public License v3.0
544 stars 65 forks source link

Separate bindings for scrolling #148

Open Fyren opened 4 years ago

Fyren commented 4 years ago

It seems like the keys for scrolling images with the keyboard are hardcoded as the arrow keys. They appear to override any other keybinds that are set. (This might only happen if you have mouse scrolling turned off, but I didn't test since I leave it off.) For example:

Bind previous/next image to left and right arrows Open an image (and zoom in if it's not bigger than the display area) Hit left/right

This will result in scrolling the image left and right, not changing the image. If you zoom out so the image isn't scrollable, then left/right will change the image.

I would like to request to be able to change the four keys for scrolling in the key binds window.

kanryu commented 4 years ago

As you pointed out. QuickViewer fixedly assigns the input of the arrow keys to scroll the image when the image is larger than the window and the scroll bar is displayed.

This is because it is the original behavior of scrollbars in each OS, and applications should not prevent such behavior.

There is a deep maze in image scrolling, which can be a very complex issue when you start digging deeper. Currently QuickViewer is not interested in the problem.

Specifically, it's when you zoom in on your scrapbook. When you go to the far right with the right cursor, you want it to go back to the far left and move some down. Is it always the right behavior? How much should you scroll down? This is called the Z-shaped scroll problem. The appropriate parameters are different in different cases. Should it be possible to customize it?

Fyren commented 4 years ago

This is because it is the original behavior of scrollbars in each OS

Even so, there are no scrollbars visible. I don't think users will consider how they behave. I do think scrolling with the arrow keys is a good default.

However, knowing that I set my key binds to left/right arrows, I expected them to work. If you won't implement my request, then maybe disallow binding the arrow keys. (My first thought when I encountered this behavior was that it was a bug and I saw issue #65 when searching, but decided to file this as a request instead.)

and applications should not prevent such behavior.

If you turn on "scroll with the mouse while zooming," then QuickView does prevent it. If you enable that, then follow the steps in my first comment, the left and right arrow keys will not scroll the image and will move to the previous/next image instead.

There is a deep maze in image scrolling.

I can believe that there are a lot of possible issues involving scrolling. My desire is just to make the existing behavior work with the key binds I want.

Thank you for taking the time to respond.