search

kanryu / quickviewer

A image/comic viewer application for Windows, Mac and Linux, it can show images very fast
https://kanryu.github.io/quickviewer/
GNU General Public License v3.0
536 stars 63 forks source link

Crash on incorrect file #35

Closed GitHubRulesOK closed 6 years ago

GitHubRulesOK commented 7 years ago

if a file, folder, sub-folder or zip contains a file with incorrect type (any of these 4 cases) quickviewer will crash where other apps report incorrect file type

as an example I tried opening a folder that contained sample.pdf that was incorrectly named as sample.png

kanryu commented 7 years ago

Thank you for your report.

This problem will be fixed on next release.

GitHubRulesOK commented 7 years ago

I am impressed at the speed with which you resolve issues I was unable to run versions 0.8 due to hardware issues (intel mobile drivers on touchscreen) However 0.9 is generally stable except for these odd files which took a while to spot the cause as there was no warning. I had to move files around and use a binary chop to find the offending file.

kanryu commented 7 years ago

Improved behavior in 32 bit environment with v0.8.9, and stopped using OpenGL in v0.9.3. With these changes QuickViewer had begun running more consistently on your PC.

A retry was implemented when the image was not able to be read correctly by v0.8.9 correction, but it caused a stack overflow because it is a recursive call.

This issue will not occur in the next release as we set an upper limit for retries.

kanryu commented 6 years ago

@GitHubRulesOK I made it :)

GitHubRulesOK commented 6 years ago

Bug as reported is corrected does not crash (simply shows blank page)

untitled