search

kanryu / quickviewer

A image/comic viewer application for Windows, Mac and Linux, it can show images very fast
https://kanryu.github.io/quickviewer/
GNU General Public License v3.0
539 stars 65 forks source link

Crash when analyzing 7z file in ManageCatalogs #78

Open yaboux opened 6 years ago

yaboux commented 6 years ago

I am a beginner of Github and can only speak Japanese so please forgive me if I am impolite

  1. Add a new folder in ManageCatalogs
  2. Start work
  3. QuickViewer crashes when 7z file is included

Setup Windows10 64bit

kanryu commented 6 years ago

QuickViewer uses 7z lib as static link in official, but this library sometimes does not work properly and sometimes crashes especially when reading the old 7z archive. The cause is unknown :(

7z lib has a very special, strange structure, it is necessary to use separate source code for Windows and Linux, and it is not compatible. It may be better to stop using the static link and dynamically link the official build (dll).

yaboux commented 6 years ago

Thanks for the reply. I can use it for the time being by moving the 7z file when analyzing. I hope that it can be solved well.

GitHubRulesOK commented 6 years ago

@kanryu I have found that version 1.1.1 will close instantly when selecting a .7z whilst browsing with the LH pane as an example image Here I have no problem browsing down to the .png but if I click on the following UniExtract.7z file QuickViewer will close instantly

kanryu commented 6 years ago

@GitHubRulesOK The matter is the same cause as the content pointed out by yaboux.

7z lib has a special structure, it builds as dll or it does not work properly unless it compiles all source code of 7z lib at once (can not make static library)

In the Windows version of QuickViewer, static linking is done with a dedicated hack, but it may be a problem. Next time I'll dynamically link and run the official dll of 7z.