search

kanryu / quickviewer

A image/comic viewer application for Windows, Mac and Linux, it can show images very fast
https://kanryu.github.io/quickviewer/
GNU General Public License v3.0
536 stars 63 forks source link

Minor website JavaScript issue #87

Open GitHubRulesOK opened 6 years ago

GitHubRulesOK commented 6 years ago

inline Help > "check version in browser" redirects to

https://kanryu.github.io/quickviewer/checkversion/?ver=1.1.1 Result is shown correct in my portable Firefox as Current QuickViewer version is: 1.1.1

however in a secured I.E. (limited java) the following default line is run <p>Current QuickViewer version is: <strong id="current" >no version</strong></p>

Current QuickViewer version is: no version Your QuickViewer version is: 1.1.1

It may be better to show a message such as "Sorry your browser has Java disabled" or update now as a hardcoded default value (now 1.1.1) and then on each release have the page automatically updated , worst case is the page may lag behind until someone points it out?

P.S. I note on the same page this line

Version Cheking - QuickViewer

should be

Version Checking - QuickViewer
kanryu commented 6 years ago

As you have already noticed, this simple check page allows you to check the latest version without actually going to the Release page.

The version of QuickViewer you are running now is set to the query parameter 'ver'. The official version of QuickViewer is retrieved using JavaScript's Ajax function, which is a string in the file of another domain.

Depending on the policy of the browser, this page may not be displayed correctly in some cases. But please forgive me.

Web sites autogenerated by GitHub can not include dynamic content, so we have to run JavaScript to express it. Including the official page of QuickViewer.