Gifford47 commented 1 year ago

Thank you for your interest into contributing to OctoPrint-PSUControl, it's highly appreciated!

Before submitting please make sure you have ticked all points on this checklist:

[x] Your PR targets the devel branch.
[x] Your PR was opened from a custom branch on your repository (no PRs from your version of master or devel please)
[x] Your PR only contains relevant changes: no unrelated files, no dead code, ideally only one commit - rebase your PR if necessary!
[x] Your changes follow the existing coding style.
[x] You have tested your changes (please state how!)

Feel free to delete all this help text, then describe your PR further. You may use the template provided below to do that. The more details the better!

What does this PR do and why is it necessary?

it´s on top of PR #234 but with the difference of using timer. its tested multiple times und works great!

How was it tested? How can it be tested by the reviewer?

Set a post connect delay in the options and connect to printer with the ui button.

Any background context you want to provide?

see #234

What are the relevant tickets if any?

234

Screenshots (if appropriate)

Further notes

kantlivelong commented 1 year ago

Wouldn't this be more of a "pre connect delay" which would be satisfied by "postOnDelay" ?

Gifford47 commented 1 year ago

Yes, technically, actually. I also had trouble with the naming at first. Since I originally took the code from the author, the "post" refers to the action after the button is pressed. Maybe it depends on how you look at it :)

Feel free to rename it :)

Gifford47 commented 11 months ago

@kantlivelong are planning to implement this PR?

Gifford47 commented 4 months ago

@kantlivelong is this repo actually maintained?

kantlivelong commented 4 months ago

@kantlivelong is this repo actually maintained?

Pretty much break/fix for now.

Gifford47 commented 4 months ago

My PR is now tested over 1 year with no further issues. Can you merge it?

paccerdk commented 1 month ago

Please merge. There's currently a handful of forks, dealing with this particular problem. Judging by that, this seems to be the main problem that people actively deal with - this is a problem that needs fixing.

I've been applying this patch manually for the last year while waiting for a merge (since this is what is in the plugin repository)

If the repository isn't actually going to be maintained (as in, merge pull request for fixes) please let us know.

kantlivelong / OctoPrint-PSUControl

Adding an option "Post Connect Delay" (enhances #234) #269