kantlivelong / OctoPrint-SmartPreheat

GNU Affero General Public License v3.0

24 stars 6 forks source link

Adressing the issues I mentioned #8

Closed LMS0815 closed 4 years ago

LMS0815 commented 4 years ago

This is to address the issues I raised in the master branch

kantlivelong commented 4 years ago

Can you let me know if 0.0.3 fixed your issue before continuing here?

4

kantlivelong commented 4 years ago

Also let's work from #4 before looking at this. I'm not sure how you are able to print without selecting a file first.

LMS0815 commented 4 years ago

See my comment on https://github.com/kantlivelong/OctoPrint-SmartPreheat/issues/4

LMS0815 commented 4 years ago

Your new GCODE analyse function is much better (also I prefer mine :) ) but can be performance optimized. (Kindly check my approach).. Please only use "WAIT tor temp" statements only for analysis (or offer an option in the plugin) as GCODE sometimes is using different temperatures for WAIT and SET. I assume more important is the snippet. Your version is just not working on my LINUX and just throwing errors - which means aborting.

LMS0815 commented 4 years ago

I you like to be inspired, just visit my fork.