search

kantoks / skrupel

http://www.skrupel.de
19 stars 10 forks source link

PHP 7 compatibility #65

Open BassXX opened 7 years ago

BassXX commented 7 years ago

Since the database connectivity changed in PHP 7, a redesign is needed to make Skrupel work on this PHP version.

(This issue exists just for planning purposes)

kantoks commented 7 years ago

i think switch to pdo is the best idea.

ForGorNorPor commented 7 years ago

67 makes Skrupel run on PHP 7 by using a drop-in-replacement API for deprecated mysql_ functions (see https://github.com/dshafik/php7-mysql-shim). This is meant to be a quick hack to make it work for now, because it may take a while until someone takes the time to rewrite everything to PDO.

Edit: Be warned that I only did a small test and errors might still occur. Feel free to report anything here.

BassXX commented 6 years ago

Very nice! Roughly it seems to work well.

I found one issue in the chat:

The messages are appearing as blank, no matter what you type.