search

kantord / LibreLingo

🐢 🌎 📚 a community-owned language-learning platform
https://librelingo.app
GNU Affero General Public License v3.0
1.94k stars 213 forks source link

It doesn't show what my typo is. #1192

Open luther9 opened 3 years ago

luther9 commented 3 years ago

Describe the bug In an exercise, I typed "buenos días, yo soy cecilia". The response was "You have a typo!" and "Correct spelling: Buenos días, yo soy Cecilia." There was no indication of what the typo was. LibreLingo usually ignores periods, but apparently not for this particular exercise. If I add a period, it's correct. If I capitalize the words without a period, it's a typo.

To Reproduce

  1. Click on the "Phrases" lesson.
  2. When you get to the voice exercise for "Buenos días, yo soy Cecilia.", type "buenos días, yo soy cecilia".

Expected behavior The "Correct spelling" should clearly show what caused the typo flag.

Screenshots Screenshot_2021-04-02 LibreLingo

Desktop:

kantord commented 3 years ago

Hi @luther9 thanks for the idea!

@allcontributors please add @luther9 for ideas

allcontributors[bot] commented 3 years ago

@kantord

I've put up a pull request to add @luther9! :tada:

kantord commented 3 years ago

This is not trivial to do, but not very hard either.

Basically we need to add this logic to answer-corrector and perhaps come up with a frontend design for it

luther9 commented 3 years ago

I just looked at the code for the exercises. This is the only exercise out of the whole Spanish course that has an explicit period. That explains why all the other phrases ignore periods.

I think for consistency, either all the exercises should have periods, or none of them should.

When writing this bug report, I assumed there was something special about this sentence that tripped up something in the algorithm, which I can now see was wrong. The solution I suggested in my bug report might still be useful for hard-to-see typos or for catching bugs in the course YAML.

kantord commented 3 years ago

I think for consistency, either all the exercises should have periods, or none of them should.

I would say none of them should, and it should be somehow enforced

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

an-spideog commented 1 year ago

I'm looking at doing this one, should the answer-corrector still be used? It looks like Listening challenge implements its own answer corrector.

kantord commented 1 year ago

yeah, answer corrector should be used, and I think it should be used in all cases :thinking: