kantord / LibreLingo

🐢 🌎 📚 a community-owned language-learning platform
https://librelingo.app
GNU Affero General Public License v3.0
1.97k stars 215 forks source link

Missing bangla definitions #1616

Open gdomingu opened 3 years ago

gdomingu commented 3 years ago

Describe the bug yarn exportCourse bangla-from-english fails due to missing definitions.

To Reproduce Steps to reproduce the behavior:

  1. run yarn exportCourse bangla-from-english

Expected behavior ✅ Exported course bangla-from-english

Screenshots

⏳ Exporting course bangla-from-englishTraceback (most recent call last):
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/export.py", line 30, in _export_skill
    skill_data = _get_skill_data(skill, course)
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/skills.py", line 13, in _get_skill_data
    "challenges": _get_challenges_data(skill, course),
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/challenges.py", line 62, in _get_challenges_data
    _make_challenges_using(_get_phrase_challenges, skill.phrases, course),
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/challenges.py", line 13, in _make_challenges_using
    for challenge in callback(data_item, course):
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/challenges.py", line 39, in _get_phrase_challenges
    return _challenge_mapper(
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/challenges.py", line 29, in map_challenge_creators
    for challenge in challenge_type_callback(item, course):
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/challenge_types.py", line 159, in get_chips_challenge
    "phrase": _define_words_in_sentence(
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/dictionary.py", line 65, in _define_words_in_sentence
    return [_define_word(course, word, reverse) for word in words]
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/dictionary.py", line 65, in <listcomp>
    return [_define_word(course, word, reverse) for word in words]
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/dictionary.py", line 52, in _define_word
    raise ValueError(
ValueError: The Bangla word "তোমার" does not have a definition. Please add it to the mini-dictionary.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "librelingo_json_export/cli.py", line 42, in <module>
    _command()
  File "/home/codespace/.cache/pypoetry/virtualenvs/librelingo-json-export-oTdPRWce-py3.8/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/home/codespace/.cache/pypoetry/virtualenvs/librelingo-json-export-oTdPRWce-py3.8/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/home/codespace/.cache/pypoetry/virtualenvs/librelingo-json-export-oTdPRWce-py3.8/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/codespace/.cache/pypoetry/virtualenvs/librelingo-json-export-oTdPRWce-py3.8/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
  File "librelingo_json_export/cli.py", line 38, in _command
    export_course(output_path, course, settings)
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/export.py", line 93, in export_course
    _export_course_skills(export_path, course, settings)
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/export.py", line 19, in _export_course_skills
    _export_skill(export_path, skill, course, settings)
  File "/workspaces/LibreLingo/apps/librelingo_json_export/librelingo_json_export/export.py", line 32, in _export_skill
    raise RuntimeError(
RuntimeError: Error while exporting skill "Nature": The Bangla word "তোমার" does not have a definition. Please add it to the mini-dictionary.
⚠️  Couldn't export course bangla-from-english
kantord commented 3 years ago

thanks @gdomingu!

@allcontributors please add @gdomingu for bugs

allcontributors[bot] commented 3 years ago

@kantord

I've put up a pull request to add @gdomingu! :tada: