search

kantord / LibreLingo

🐢 🌎 📚 a community-owned language-learning platform
https://librelingo.app
GNU Affero General Public License v3.0
1.96k stars 214 forks source link

Port Python code style checks (black, pylint) to GitHub Actions #2466

Closed kantord closed 2 years ago

kantord commented 2 years ago

Look at this commit that ports the mypy checks from Semaphore CI to GitHub Actions: https://github.com/LibreLingo/LibreLingo/pull/2465/commits/a09e4899f55d7e53b17fb569197fc2f3cf676c45

This task should be very simple, just repeat the same step for black and pylint, so that all of those checks are executed using GitHub Actions instead of Semaphore CI.

frey0-0 commented 2 years ago

I would like to work on this issue. Can you please assign it to me?

kantord commented 2 years ago

sure @Frey0-0 ! :1st_place_medal:

frey0-0 commented 2 years ago

@kantord I have completed this issue and also made a PR. Can you please assign this issue a hacktoberfest label as well?

kantord commented 2 years ago

I think it's not necessary to assign such a label to the issues itself, the label is already assigned to the project. If you log in into your hacktoberfest profile, you should be able to see your PR already. Do you see it?

frey0-0 commented 2 years ago

oh yes, I do see it thanks @kantord for the information :)