Uprade Python dependency `mypy` to v1

kantord / LibreLingo

🐢 🌎 📚 a community-owned language-learning platform

https://librelingo.app

GNU Affero General Public License v3.0

1.94k stars 214 forks source link

Uprade Python dependency `mypy` to v1 #2682

Open kantord opened 1 year ago

kantord commented 1 year ago

An automatic update for this Python dependency was made, but the pipelines are failing and it looks like it must be because ther eis some breaking change, or this new version requires some specific steps to update.

See the pipeline failures: https://github.com/LibreLingo/LibreLingo/actions/runs/4108224211/jobs/7088667727

Acceptance criteria:

update mypy tot the latest version
create a MR with this update
make sure that the pipelines pass. check out their documentation to see what needs to be done and if necessary, make small adjustment in our code

deepgohil commented 1 year ago

I would like to solve this issue. Can you tell me how to do it?

kantord commented 1 year ago

I would like to solve this issue. Can you tell me how to do it?

Hi! Sure. You have to start by forking the repo, cloning it on your computer and updating the mypy dependency. In order to see how to do that, you can google something like python poetry upgrade dependency or sth like that. You can test if you have any failures using poetry run mypy apps. Before the update I see no failures there, but after the update I do. You have to fix those failures and create a pull request

rahulbollisetty commented 1 year ago

hi there, is this issue still open to work?

kantord commented 1 year ago

hi there, is this issue still open to work?

yes! go for it if you'd like to try!

palakshivlani-11 commented 1 year ago

Hi ! is this issue still open?

rahulbollisetty commented 1 year ago

hi there, is this issue still open to work?

yes! go for it if you'd like to try!

Hi, @kantord, I have checked for the issue you mentioned, I have installed all dependencies and updated them too on my local machine, but found no error as mentioned in the issue.

kantord commented 1 year ago

hi there, is this issue still open to work?

yes! go for it if you'd like to try!

Hi, @kantord, I have checked for the issue you mentioned, I have installed all dependencies and updated them too on my local machine, but found no error as mentioned in the issue.

can you please create a pull request to see what happens in the CI? Maybe you will still get some errors in CI?

rahulbollisetty commented 1 year ago

hi there, is this issue still open to work?

yes! go for it if you'd like to try!

Hi, @kantord, I have checked for the issue you mentioned, I have installed all dependencies and updated them too on my local machine, but found no error as mentioned in the issue.

can you please create a pull request to see what happens in the CI? Maybe you will still get some errors in CI?

I have opened a PR, as I see all checks are passed PR 2822

belarminojosue commented 1 year ago

Hello, is this issue still open?

keshavkumar03 commented 5 days ago

hi there, is this issue still open to work , can i work on it ?