kantord / LibreLingo

๐Ÿข ๐ŸŒŽ ๐Ÿ“š a community-owned language-learning platform
https://librelingo.app
GNU Affero General Public License v3.0
1.95k stars 213 forks source link

Add ability to link to online dictionaries #3380

Open Skivling opened 2 months ago

Skivling commented 2 months ago

Creating a course, I want to link to a relevant online dictionary so the learner can get proper definitions of the words.

This could be shown in the UI if there is ever a dictionary page where a learner can look through the words in the course.

I want this feature for my LL-based application, will be adding it on top anyway but it's nice to have support in LibreLingo normally.

kantord commented 2 months ago

what about allowing courses to have a resources.md file that is similar to the explanation .md files for each skill, but it is on the course level :thinking:

Skivling commented 2 months ago

The point is to be able to put these links in an in-app dictionary so the LibreLingo course doesn't have to provide dictionary-level definitions for words. For my course, Te Reo Mฤori, the de-facto dictionary is https://maoridictionary.co.nz and for learners to be able to be looking through an in-app dictionary which shows the words they've learned, where they're included in sentences in the course etc, then be able to click through to an online dictionary entry for it to get the full understanding of the definition would be great.

For example:

New words:
  - Word: tahi
    Translation: one
    Also accepted: 1
    Dictionary Link: https://maoridictionary.co.nz/word/7059
    Images:
      - one1
      - one2
      - one3

If it was a markdown file how would that be read by applications?

On another note, it would be nice to be able to link to other resources for the learner, because just a LibreLingo course is never going to be able to cover nuances, culture, etc; and for these to be displayed in a nice way in the UI.

kantord commented 2 months ago

I would say that depending on an external dictionary that way is a bit tricky because it's an external dependency that you have no control over. If they change how the website works, or change the license to prohibit this use it will break your course and it will be very hard to fix it because you will have to replace how every single word is implemented in your course before the course can be fixed/go back online.

kantord commented 2 months ago

The markdown could just be rendered as a documentation page. In that case if the link becomes dead it's not a dramatic problem, all you would have is a single dead link

Skivling commented 2 months ago

Hadn't thought of that issue.