search

kantord / i3-gnome-pomodoro

:tomato: Integrate gnome-pomodoro into i3
GNU General Public License v3.0
224 stars 16 forks source link

issue on delayed notifications #16

Closed iovanom closed 4 years ago

iovanom commented 4 years ago

When the break phase is started all notifications from active phase are displayed. I think the logic should be the opposite.

kantord commented 4 years ago

What do you mean by opposite logic? That the notification should be displayed in the active period, and hidden during the break?

The main purpose of this is getting rid of distractions during the active period, not the idea of having them during the breaks. In fact it doesn't matter if you are on a break or have pomodoros disabled, you'll still see notifications.

iovanom commented 4 years ago

oh, then this is clear for me. I thought that we need to show the notification after the break to not skip some notifications when we are on the break :) then sorry for this comment

kantord commented 4 years ago

That's ok!

Also, I'm not against adding the possibility of overriding this behavior, if your use case requires something else. I'll gladly take a MR :-)