kanzitelli / rnn-starter

๐Ÿคน React Native Starter - Powered by cli-rn, React Native Navigation, Expo Modules, RNN Screens, RN UI lib, MMKV, Mobx, Reanimated 2, Dark Mode, Splash Screen, Localization, Notifications, Permissions, and much more.
https://starters.dev
MIT License
551 stars 72 forks source link

Renaming the project doesn't work. #43

Closed Yasir5247 closed 3 years ago

Yasir5247 commented 3 years ago

When i ran yarn rename "Aiminaabee" the files inside the ios directory doesn't rename to the new name.

RNNStarter.xcodeproj RNNStarter.xcworkspace RNNStarter RNNStarterTests

These files don't change.

before renaming i updated the app.json file like so: app.json { "name": "Aiminaabee", "displayName": "Aiminaabee" }

What am I missing here.

kanzitelli commented 3 years ago

hi @Yasir5247. yarn rename command uses react-native-rename's script. So you need to run yarn rename Aiminaabee and then run yarn ios:pods, so it's fully applied for iOS. Let me know how it goes :)

Yasir5247 commented 3 years ago

This is what i did

1- git clone https://github.com/kanzitelli/rnn-starter.git Aiminaabee && cd Aiminaabee 2- rm -rf .git 3- yarn && yarn ios:pods 4- yarn rename Aiminaabee 5- yarn ios:pods

I can still see the file names not changed inside the ios folder.

โฏ yarn rename Aiminaabee yarn run v1.22.10 $ npx react-native-rename Aiminaabee npx: installed 80 in 6.206s Can't find an ios path or project. Make sure that the ios project path and property 'name' in app.json the same. mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee-tvOS Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee-tvOSTests Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee.xcodeproj Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee.xcodeproj/xcshareddata/xcschemes/Aiminaabee-tvOS.xcscheme Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee.xcodeproj/xcshareddata/xcschemes/Aiminaabee.xcscheme Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/AiminaabeeTests Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/AiminaabeeTests/AiminaabeeTests.m Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee.xcworkspace Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee/Aiminaabee.entitlements Ignore above error if this file doesn't exist mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/ios/Aiminaabee-Bridging-Header.h Ignore above error if this file doesn't exist /android/app/src/main/res/values/strings.xml MODIFIED /index.js MODIFIED /package.json MODIFIED /app.json MODIFIED /android/settings.gradle MODIFIED /ios/Podfile MODIFIED /app.json MODIFIED android/app/src/main/java/com/rnnstarter BUNDLE IDENTIFIER CHANGED /android/app/src/main/AndroidManifest.xml MODIFIED /android/app/_BUCK MODIFIED /android/app/build.gradle MODIFIED /android/app/src/main/java/com/rnnstarter/MainActivity.java MODIFIED /android/app/src/main/java/com/rnnstarter/MainApplication.java MODIFIED /android/app/src/main/java/com/rnnstarter/MainActivity.java MODIFIED mv: no such file or directory: /Users/aliyasir/Documents/DEV-WIP/AIMINAABEE/bee-mobile/bee-mobile-TS/Aiminaabee/android/app/src/debug/java/com/rnnstarter/* Error moving: "android/app/src/debug/java/com/rnnstarter" "android/app/src/debug/java/com/rnnstarter" /android/app/src/main/AndroidManifest.xml MODIFIED /android/app/_BUCK MODIFIED /android/app/build.gradle MODIFIED Done removing builds. APP SUCCESSFULLY RENAMED TO "Aiminaabee"! ๐ŸŽ‰ ๐ŸŽ‰ ๐ŸŽ‰ Podfile has been modified, please run "pod install" inside ios directory. Please make sure to run "watchman watch-del-all" and "npm start --reset-cache" before running the app. โœจ Done in 9.68s.

kanzitelli commented 3 years ago

hi @Yasir5247. I have just followed the same steps you provided and this what I got: Screenshot 2021-07-13 at 14 37 10 Screenshot 2021-07-13 at 14 37 56

I couldn't reproduce your error, unfortunately. As an option, you can try using cli-rn how described in Quick start section.

leicaand commented 3 years ago

Same problem here

kanzitelli commented 3 years ago

@Yasir5247 @leicaand you can also try react-native-rename-next

Yasir5247 commented 2 years ago

photo_2022-01-17_10-35-13

renaming the project still doesnt work for me. i tried with windows, and with a friends computer. still ios directory folders name starts with RNNStarter. what am i missing here.

from the above screen shot. does it mean i have to manually rename folder name's in the ios directory to match the name in the app.json file?

my app.json file. { "name": "Aiminaabee", "displayName": "Aiminaabee" }