search

kaoh / globalplatform

C library + command-line for Open- / GlobalPlatform smart cards
https://kaoh.github.io/globalplatform/
Other
73 stars 29 forks source link

Use MAJOR version as SOVERSION. #79

Closed jas4711 closed 11 months ago

jas4711 commented 11 months ago

The SONAME for libglobalplatform.so and libgppcscconnectionplugin.so are 'libglobalplatform7.3.0' and 'libgppcscconnectionplugin1.2.4', respectively, which looks wrong. This pull request turns the sonames into 'libglobalplatform7' and 'libgppcscconnectionplugin1' instead. What do you think?

This may trigger an ABI bump if someone packaged the libraries for a distribution that cares about shared library versioning, but I'm not sure that is the case?

This was caused by Debian lintian:

W: libglobalplatform7: package-name-doesnt-match-sonames libglobalplatform7.3.0
N: 
N:   The package name of a library package should usually reflect the soname of
N:   the included library. The package name can determined from the library
N:   file name with the following code snippet:
N:   
N:    $ objdump -p /path/to/libfoo-bar.so.1.2.3 | sed -n -e's/^[[:space:]]*SONAME[[:space:]]*//p' | \
N:        sed -r -e's/([0-9])\.so\./\1-/; s/\.so(\.|$)//; y/_/-/; s/(.*)/\L&/'
N: 
N:   Visibility: warning
N:   Show-Always: no
N:   Check: libraries/shared/soname