search

kaoh / globalplatform

C library + command-line for Open- / GlobalPlatform smart cards
https://kaoh.github.io/globalplatform/
Other
73 stars 29 forks source link

RSA exponent size incorrect in code comments #87

Closed pspacek closed 9 months ago

pspacek commented 9 months ago

I believe this comment is incorrect: https://github.com/kaoh/globalplatform/blob/1fe699635bdbe6773ebc458140b8791acc4493ac/globalplatform/src/crypto.c#L2080

The comment says 65337 (0xff39), but I think it meant the usual 65537 (0x10001). 65337 has small factors...

kaoh commented 9 months ago

Right, the comment seems to be wrong. Fixed now. Thanks.