kaorahi / lizgoban

Leela Zero & KataGo visualizer
GNU General Public License v3.0
171 stars 29 forks source link

Is endstate_option deprecated? #117

Closed qcgm1978 closed 6 months ago

qcgm1978 commented 8 months ago

According to the following code, it seems that endstate_option configured in config.json should be an array. However, this configuration is not mentioned in the project, which means it is no longer valid. Was it abandoned because it did not have obvious benefits? Since I want to modify this project locally to make it more in line with my ideas, I want to delete the invalid code.

function start_endstate(given_start_args, endstate_option) {
    const [lz_command, x] = endstate_option
    ...
}
kaorahi commented 8 months ago

See OBSOLETE.md. :)

I'd like to remove the code for this obsolete feature to clean up the codebase someday (#46).

In the past, this hybrid approach using multiple engines was the only way for me to obtain strong moves and acceptable score estimations at the same time. Now, KataGo is absolutely preferred, offering both with better accuracy through a single engine, eliminating the hassle of managing multiple engines.

qcgm1978 commented 8 months ago

Can it be understood that Leela Zero no longer requires support? [If so, that would significantly reduce the complexity of the code. I also rarely use Leela Zero.]

kaorahi commented 8 months ago

No. I'll keep supporting other GTP engines including Leela Zero, Leela (patched), and TamaGo. What I mentioned is a special variant of LZ equipped with an additional endstate_map command. Please refer to OBSOLETE.md for details.

Of course, you can remove their support from your fork freely.

kaorahi commented 6 months ago

I'm planning to delete endstate_leelaz soon (504b09dcb) and reuse its code for Human supervised learning net.

https://github.com/kaorahi/lizgoban/blob/humansl_proto1/README_HumanSL.md