search

kaosagnt / toolbox2docker

Toolbox utilities for Docker on macOS / Windows
18 stars 2 forks source link

feature request: version without vbox #13

Open egandro opened 3 months ago

egandro commented 3 months ago

I have a (maybe silly) feature request.

Can you offer a version without vbox bundled?

Thank you.

kaosagnt commented 3 months ago

You don't have to install virtual box. Do a custom install by deselecting virtual box. Why do you need a virtual box removed?

egandro commented 3 months ago

You don't have to install virtual box. Do a custom install by deselecting virtual box. Why do you need a virtual box removed?

It's more about the download size.

Having a version without the VBox installer

https://github.com/kaosagnt/toolbox2docker/blob/44e9ff5cffb45bd71df38774fca733fdb462e35b/Dockerfile.windows#L100

is simple to create - we just need a 2nd Dockerfile or parameterize the Dockerfile.

Would you accept a PR?

kaosagnt commented 3 months ago

Sure, Let's see what you come up with.

egandro commented 3 months ago

Have a look at my PR.