Fix direct file access on Wasm - Githubissues

kaosat-dev / Blenvy

Bevy Code & Blender addon for a simple workflow to add & edit Bevy components in Blender

Other

592 stars 55 forks source link

Fix direct file access on Wasm #199

Closed janhohenheim closed 3 months ago

janhohenheim commented 3 months ago

Notes:

Makes RawGltfAsset pub so that a user could in theory preload it, but that's super ugly.
Restricts some access modifiers while we're on it
Runs cargo fmt
Uses from_slice_without_validation and not from_reader_without_validation because our reader is async only, which does not implement the general Reader trait.

Future work:

Improve preloading story (not sure how?)
Only parse relevant parts of gltf
Run blueprints_prepare_spawn only on AssetEvent::LoadedWithDependencies

kaosat-dev commented 3 months ago

Awesome work as always @janhohenheim ! Thanks for the quick fix & tweaks, merging !