search

kaoz70 / grapesjs-blocks-bootstrap4

GrapesJS Bootstrap v4 Blocks Plugin
BSD 3-Clause "New" or "Revised" License
153 stars 106 forks source link

bs 5 update ? #52

Open micker opened 3 years ago

micker commented 3 years ago

hello did you plan to update to bootstrap 5 ? regards

kaoz70 commented 3 years ago

Yes, its something I have been thinking about for a while but haven't gotten my head around of how to do it yet:

Should I create a new repo? Should I create a new branch and rename this repo?

Since this repo was originally created for Bootstrap's version 4.

micker commented 3 years ago

a new branch ?

lane711 commented 3 years ago

I have the same question - It would probably make sense to create a new branch instead of a separate repo, at least for initial development. Bootstrap 5 doesn't have as many breaking changes as encountered going from bs3 to 4 so I wouldn't anticipate a massive amount of changes.

I'm evaluating using GrapeJS in an Nodejs based CMS that I have been working on for a couple+ years : https://github.com/lane711/sonicjs

Grape looks pretty awesome so I'm exited about the possibilities here but definitely need to support Bootstrap 5.

lane711 commented 3 years ago

Here is a separate fork/branch with Bootstrap 5. I had to make a couple small changes, but seems to work pretty well so far: https://github.com/lane711/grapesjs-blocks-bootstrap4/tree/bootstrap-5

micker commented 3 years ago

cool thanks !