search

kapicorp / kapitan

Generic templated configuration management for Kubernetes, Terraform and other things
https://kapitan.dev
Apache License 2.0
1.83k stars 200 forks source link

fix: import libmagic only when its needed #1083

Closed MatteoVoges closed 11 months ago

MatteoVoges commented 1 year ago

Fixes #1078

Proposed Changes

ademariag commented 11 months ago

@MatteoVoges why don't we add libmagic to the dependencies?

MatteoVoges commented 11 months ago

@MatteoVoges why don't we add libmagic to the dependencies?

I have to search if libmagic is available as python pip package, because it's the only apt/brew dependency. Maybe there exists an up-to-date python lib that unpacks downloaded files.

I think it we should find a solution for it, because having kapitan not working after using pip / poetry install shouldn't be the case.