search

kapicorp / kapitan

Generic templated configuration management for Kubernetes, Terraform and other things
https://kapitan.dev
Apache License 2.0
1.8k stars 198 forks source link

Install reclass as module #1133

Closed ademariag closed 7 months ago

ademariag commented 7 months ago

Fixes #

Proposed Changes

*

Docs and Tests

MatteoVoges commented 7 months ago

@ademariag Could you add the tests for submodules back again? Maybe we have to find a lightweight test-repo with submodules, that we can download. But just because the tests fail with kapitan, because we removed reclass, we should continue testing it with other repos. Thanks in advance

ademariag commented 7 months ago

Why do we need to test the submodule capability? It made sense when reclass was sourced that way. Is there a real use case for it?

MatteoVoges commented 7 months ago

Why do we need to test the submodule capability? It made sense when reclass was sourced that way. Is there a real use case for it?

It was a feature and is documented. See #914 #987 and https://kapitan.dev/pages/external_dependencies/?h=submodule#defining-dependencies