kapicorp / kapitan

Generic templated configuration management for Kubernetes, Terraform and other things
https://kapitan.dev
Apache License 2.0
1.8k stars 197 forks source link

Jsonnet doesn't remember file mode #506

Open pvanderlinden opened 4 years ago

pvanderlinden commented 4 years ago

Describe the bug/feature When you render a file with the jinja2 input type, it remembers the file mode (e.g. executable). With the jsonnet input type this is not working.

To Reproduce Steps to reproduce the behavior:

Expected behavior the output file apply.sh should have the same file mode as the input template

sanyam1997 commented 4 years ago

Hey, I would like to work on this issue. I am a first-time contributor. Can you suggest relevant resources to be studied for working on this issue?

ramaro commented 4 years ago

Hey @sanyam1997 this particular issue requires a bit more thought as jsonnet per se does not allow doing this. An idea to solve this issue is to allow setting a new option in the inventory to set the mode file permissions for a particular pattern of files. I suggest you have a look at the inputs/base.py which already has basic support for this, but needs to be rethought.

sanyam1997 commented 4 years ago

Hey @ramaro, I am new to open source and was looking for some guidance during the initial phase of open source contribution. Can you please email me at rajpalsanyam1997@gmail.com?

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open for 1 year with no activity. Remove the stale label or comment if this issue is still relevant for you. If not, please close it yourself.