kapicorp / kapitan

Generic templated configuration management for Kubernetes, Terraform and other things
https://kapitan.dev
Apache License 2.0
1.8k stars 197 forks source link

Issue: release notes for v0.29.5 incorrectly states that jsonnet was bumped to v0.17 (while it stayed at v0.16) #736

Open GoodDingo opened 3 years ago

GoodDingo commented 3 years ago

Issue: jsonnet version was NOT really bumped in release 0.24.5

... mostly because of questionable requirements.txt and Pipenv and install_requires "con-fusion" ...


Jsonnet still at 0.16 and NOT upgraded in 0.24.5

Even though Pipfile was upgraded to jsonnet ==0.17.0, the real dependency for the python package is defined in setup.py and it reads requirements.txt that contains some "interesting" versions along with jsonnet==0.16.0.

To Reproduce

$  conda create -n new_kapitan_env python=3.8
$  conda activate new_kapitan_env
$  pip install kapitan==0.29.5
$  kapitan --version
0.29.5

$   pip freeze | egrep jsonnet
jsonnet==0.16.0

or oneliner for docker image

$  docker run -it --entrypoint pip deepmind/kapitan:v0.24.5 freeze | grep jsonnet

jsonnet==0.16.0

Expected behavior

For kapitan v0.29.5, dependencyjsonnet is in version v0.17.0 as stated in release doc (third line).

$  docker run -it --entrypoint pip deepmind/kapitan:v0.29.5 freeze | grep jsonnet

jsonnet==0.17.0

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open for 1 year with no activity. Remove the stale label or comment if this issue is still relevant for you. If not, please close it yourself.