search

kapieyow / pickem

2 stars 4 forks source link

Add web functionality for a user to change their player tag for a league #32

Open kapieyow opened 5 years ago

kapieyow commented 5 years ago

This can only be done in the API currently. Add web functionality for a user to update their own player tag. NOTE this can be different by league. Maybe a "user profile" dialog that lists the leagues a user is in and allows the tags to be updated. Should probably put some length limitations on the tag and I would guess should strip some special characters.

After this is in place add tooltips wherever the player tag is displayed to show user name

gudenkauf commented 5 years ago

This is the next thing I plan to work on. However, if you get to it first then let me know. Thanks!

kapieyow commented 5 years ago

Rock on sir. Not planning on getting into this one. I know there are people that would like to have this functionality.

Random "tips" If you want to use a dialog, the NCAAF - Pick'em header has one in top nav. The player tag click in the header at the top right logs out currently. Feel free to make it do this instead of it makes sense. I doubt anyone even knows it logs out. All that said, feel free to be creative doesn't have to do any of that.

Right now the API LeagueController.PutPlayer is god only. Easy to just cut that authorization policy in the attribute. Then of course any authed user can modify anybody else's tag. There is a some questionable code in LeagueController.PutPlayerPick that makes sure users can only modify their own tag.