kapilt / getpaid

Automatically exported from code.google.com/p/getpaid
0 stars 0 forks source link

Products can be marked IBuyable and IShippable #131

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?

1. Making a shippable product adds an item to the portlet that I can
add to my cart for the shipping product price.  

2. Subsequently making the same product buyable changes the price of the
same item.  

3. This negates the shipping cost of the item. Which no longer appears as
avaiable on the item; and is also NOT applied at checkout. 

I think IIRC the main problem is that one shouldn't be able to mark a
product both a shippable product and a buyable product.

I think john Lenton may have been working/fixing that at the sprint, but
don't recall the status.

Original issue reported on code.google.com by reedobrien on 21 Oct 2007 at 3:32

GoogleCodeExporter commented 8 years ago
To me this is fixed now. Can someone confirm?

Original comment by lucielej...@gmail.com on 6 Mar 2008 at 3:00

GoogleCodeExporter commented 8 years ago
With v0.6.1, I can replicate this issue. :(

1. Made Page content type Buyable and Shippable (via "GetPaid Setup: Content 
Types"
settings panel)
2. Created a new Page (pageGuy).
3. Added Shopping Cart, Shippable, and Buyable portlets (via "Manage Portlets").
4. Selected "Actions > Make Shippable Product" and filled in fields (Price: 10).
5. Selected "Actions > Make Buyable" and filled in the fields (Price: 5).
Price in portlets is 5.

The Payable content view (someObject/@@edit-payable) says "Made Payable By" at 
the
top and has the following fields: Product Code, Price, Dimensions, Product SKU,
Shipping Weight, Weight Unit.

If one shouldn't be able to mark an object both shippable and buyable, I can 
think of
at least two solutions. See PloneGetPaid/browser/content.py:
(a) For PayableCreation (L90), also do what a call to ShippableDestruction
(L160)does. For ShippableCreation (L155), also do what a call to 
PayableDestruction
(L127)does.

OR

(b) In PloneGetPaid/browser/content.py: For allowMakeBuyable (L254), add the
condition "and not self.isShippable". For allowMakeShippable (L270), add the
condition "and not self.isBuyable".

Original comment by mcgruff....@gmail.com on 22 Aug 2008 at 6:02

GoogleCodeExporter commented 8 years ago
Still not fixed as of today

Original comment by lucielej...@gmail.com on 15 May 2009 at 8:29