search

kapilt / juju-digitalocean

JuDo - A juju provider for digital ocean using a client side plugin and manual provisioning.
111 stars 17 forks source link

Fix 20 #21

Closed lazypower closed 10 years ago

lazypower commented 10 years ago

Fixes #20 caused by invalid image id's being in the map.

This is just a bandaid however, a smarter way to do this would be to do some exact matching on the API output, as their images are going to be deprecated at random times whenever they decide to release a new image id. I'll brain bend around how to do this and see about a follow up feature branch with it.

ubuntudemon commented 10 years ago

I updated the image list in constraints.py according to your fix. I can confirm that this works. I tested it with precise (default) and trusty:

juju docean bootstrap --constraints="mem=512M,region=ams2" --series="trusty" -v

morganhowarth commented 10 years ago

Indeed, I too updated the image list and it works as expected.

kapilt commented 10 years ago

i took a slightly different approach, added client support for fetching and images added a unit test that verifies the cached image set.