kapitainsky / RcloneBrowser

Simple cross platform GUI for rclone. Supports macOS, GNU/Linux, BSD family and Windows.
https://github.com/kapitainsky/RcloneBrowser
MIT License
2.28k stars 218 forks source link

The exclude option is never being applied to transfers #179

Open meatyalien opened 2 years ago

meatyalien commented 2 years ago

I've been having a problem where the file exclude option (--exclude) is never applied to transfers. I've tried using it in the extra options field, as well as listing the exclude patterns the dedicated exclude tab. It doesn't seem to matter what the exclude pattern is, they are never applied.

As I'm on Mac (which likes to create . files), a basic example is using --exclude ".*" to exclude the files. That does not work though. This only occurs when using RcloneBrowser. If I copy the transfer command from RcloneBrowser and run it in terminal using rclone, all the options are properly applied.

kapitainsky commented 2 years ago

Can you see what rclone command RB is using? you can see it when you press small icon on the right side of transfer stats in jobs tab

meatyalien commented 2 years ago

Wow, was not expecting that fast of a reply. Here's the command that it's using (which works fine in terminal):

/usr/local/bin/rclone sync --dry-run --delete-during --size-only --verbose --transfers 4 --checkers 8 --contimeout 60s --timeout 300s --retries 3 --low-level-retries 10 --exclude .DS_Store --exclude "._*" --exclude "/*Icon*" --exclude "/.sync/**" --delete-excluded --stats 1s --stats-file-name-length 0 --fast-list LOCALDIRECTORY REMOTE:REMOTEDIRECTORY

kapitainsky commented 2 years ago

And in comparison what is your command line which is working?

On 5 Oct 2021, at 20:31, meatyalien @.***> wrote:

Wow, was not expecting that fast of a reply. Heres the command that it's using (which works fine in terminal):

/usr/local/bin/rclone sync --dry-run --delete-during --size-only --verbose --transfers 4 --checkers 8 --contimeout 60s --timeout 300s --retries 3 --low-level-retries 10 --exclude .DSStore --exclude "." --exclude "/Icon*" --exclude "/.sync/**" --delete-excluded --stats 1s --stats-file-name-length 0 --fast-list /Users/meatyalien/Music/FLAC gsuite_crypt:Music/Personal

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kapitainsky/RcloneBrowser/issues/179#issuecomment-934711703, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXJHOWQDAUE572HR3GU6P3UFNHALANCNFSM5FMNTPWQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

meatyalien commented 2 years ago

The exact same command above works in terminal. I copied the above command from RB (which failed in RB) and pasted it into terminal and ran it (which worked).

kapitainsky commented 2 years ago

Cool. Thank you. Maybe something with parsing quotations characters… I will check

On 5 Oct 2021, at 20:33, meatyalien @.***> wrote:

The exact same command above works in terminal. I copied the above command from RB (which failed in RB) and pasted it into terminal and ran it (which worked).

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kapitainsky/RcloneBrowser/issues/179#issuecomment-934713853, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXJHOSVMO2TE4SHBGE5DNTUFNHKFANCNFSM5FMNTPWQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

meatyalien commented 2 years ago

I just did some testing and that is the problem. The quotation marks cause it to not work in RB. So while removing them fixes it for RB, rclone command line syntax requires they exist for exclusions that include wildcards. So what works for one, doesn't work for the other.

kapitainsky commented 2 years ago

Very good feedback! I will try to figure out how to tackle it.