kapitainsky / RcloneBrowser

Simple cross platform GUI for rclone. Supports macOS, GNU/Linux, BSD family and Windows.
https://github.com/kapitainsky/RcloneBrowser
MIT License
2.36k stars 221 forks source link

Issue on compile #207

Open wpeckham opened 2 years ago

wpeckham commented 2 years ago

Following ARCH steps on Pinebook Pro (AARCH64) running Manjaro 22.04 the cmake steps seem to succeed, but the make step throws this log and fails. Are there alternate steps or additional instructions to bypass this issue? RcloneBrowser/src/main_window.cpp:435:44: error: ‘QStringList QString::split(const QString&, QString::SplitBehavior, Qt::CaseSensitivity) const’ is deprecated: Use Qt::SplitBehavior variant instead [-Werror=deprecated-declarations] 435 | QStringList lines = version.split("\n", QString::SkipEmptyParts); | ~~~^~~~~~~~~ In file included from /usr/include/qt/QtCore/qobject.h:47, from /usr/include/qt/QtCore/qabstractanimation.h:43, from /usr/include/qt/QtCore/QtCore:6, from /home/wpeckham/work/RcloneBrowser/src/pch.h:9, from /home/wpeckham/work/RcloneBrowser/src/icon_cache.h:3, from /home/wpeckham/work/RcloneBrowser/src/main_window.h:3, from /home/wpeckham/work/RcloneBrowser/src/main_window.cpp:1: /usr/include/qt/QtCore/qstring.h:609:17: note: declared here 609 | QStringList split(const QString &sep, SplitBehavior behavior, | ^~~~~ /home/wpeckham/work/RcloneBrowser/src/main_window.cpp: In member function ‘void MainWindow::addStream(const QString&, const QString&)’: /home/wpeckham/work/RcloneBrowser/src/main_window.cpp:1217:16: error: ‘void QProcess::start(const QString&, QIODevice::OpenMode)’ is deprecated: Use QProcess::start(const QString &program, const QStringList &arguments,OpenMode mode = ReadWrite) instead [-Werror=deprecated-declarations] 1217 | player->start(stream, QProcess::ReadOnly); | ~~~^~~~~~ In file included from /usr/include/qt/QtCore/QtCore:170, from /home/wpeckham/work/RcloneBrowser/src/pch.h:9, from /home/wpeckham/work/RcloneBrowser/src/icon_cache.h:3, from /home/wpeckham/work/RcloneBrowser/src/main_window.h:3, from /home/wpeckham/work/RcloneBrowser/src/main_window.cpp:1: /usr/include/qt/QtCore/qprocess.h:168:10: note: declared here 168 | void start(const QString &command, OpenMode mode = ReadWrite); | ^~~~~ cc1plus: all warnings being treated as errors make[2]: [src/CMakeFiles/rclone-browser.dir/build.make:230: src/CMakeFiles/rclone-browser.dir/main_window.cpp.o] Error 1 make[1]: [CMakeFiles/Makefile2:98: src/CMakeFiles/rclone-browser.dir/all] Error 2 make: *** [Makefile:136: all] Error 2

wpeckham commented 2 years ago

Issue can be closed. There is a version in AUR that has been tuned to compile on Manjaro.

spodhajecki commented 1 year ago

I had the same errors on Ubuntu 22.04.3 LTS in main_window.cpp, changed line 435 as follows:

// QStringList lines = version.split("\n", QString::SkipEmptyParts); QStringList lines = version.split("\n", Qt::SkipEmptyParts);

Changed line 1217 as follows:

// player->start(stream, QProcess::ReadOnly); player->setProgram(stream); player->start(QProcess::ReadOnly);

ccchan234 commented 9 months ago

same finding in latest chromebook's linux. let me see if the above modify could help. thanks

Inc44 commented 9 months ago

The pull request has already been sent in July 2020 and is still awaiting approval: https://github.com/kapitainsky/RcloneBrowser/pull/126/commits/ce9cf52e9c584a2cc85a5fa814b0fd7fa9cf0152

ccchan234 commented 9 months ago

hi everybody, yeah the above modifications worked. chatgpt suggest the same modifications.

ps, it's working on mine now. thanks all.

sandy9707 commented 6 months ago

I had the same errors on Ubuntu 22.04.3 LTS in main_window.cpp, changed line 435 as follows:

// QStringList lines = version.split("\n", QString::SkipEmptyParts); QStringList lines = version.split("\n", Qt::SkipEmptyParts);

Changed line 1217 as follows:

// player->start(stream, QProcess::ReadOnly); player->setProgram(stream); player->start(QProcess::ReadOnly);

It's worked!

puppetdevz commented 1 day ago

I had the same errors on Ubuntu 22.04.3 LTS in main_window.cpp, changed line 435 as follows:

// QStringList lines = version.split("\n", QString::SkipEmptyParts); QStringList lines = version.split("\n", Qt::SkipEmptyParts);

Changed line 1217 as follows:

// player->start(stream, QProcess::ReadOnly); player->setProgram(stream); player->start(QProcess::ReadOnly);

It's worked for me!!! The info of my computer is follow: PixPin_2024-11-21_12-47-09