search

kapitainsky / RcloneBrowser

Simple cross platform GUI for rclone. Supports macOS, GNU/Linux, BSD family and Windows.
https://github.com/kapitainsky/RcloneBrowser
MIT License
2.36k stars 221 forks source link

Export's output file encoded in operating system encoding but not UTF-8 #77

Open partment opened 4 years ago

partment commented 4 years ago

Sorry for my bad English.

I'm using windows 10 x64 set with Traditional Chinese language and UTC+8 timezone.

With RcloneBrowser, the "Export" feature will output a file encoded in BIG5 which is designed to normally display Traditional Chinese. (Buggy condition)

But BIG5 has a problem with Japanese, causing some of my filenames turn into unreadable words.

With rclone command-line, rclone tree will output a file encoded in UTF-8. (Normal condition)

We all know that UTF-8 is now the standard.

kapitainsky commented 4 years ago

Definitely will investigate and try to fix - must be some Qt characters encoding magic.

partment commented 4 years ago

Definitely will investigate and try to fix - must be some Qt characters encoding magic.

I've submitted a PR.

kapitainsky commented 4 years ago

Brilliant! I am not planning another release soon but tell me what OS you are on and I will release updated version for you.

partment commented 4 years ago

Brilliant! I am not planning another release soon but tell me what OS you are on and I will release updated version for you.

I've already built for myself! :)

kapitainsky commented 4 years ago

Cool! It will then end up in the next release.

partment commented 4 years ago

It took me some times to set up the developing environment. Don't forget to close this issue after next release.

kapitainsky commented 4 years ago

I have merged it to testing branch - I keep new things there for some time until tested.

partment commented 4 years ago

According to my tests, this fix also works on csv format and successfully outputs Japanese without any exceptions or errors.

kapitainsky commented 4 years ago

UTF-8 should be standard for such output - agree. I missed it as not using often non western alphabet.