kapitanluffy / wwwsqldesigner

Automatically exported from code.google.com/p/wwwsqldesigner
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Patch for "UNSIGNED" integer types #159

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
patches to allow creating "UNSIGNED" integer types
(have tested it myself, and seems to work great)

Original issue reported on code.google.com by divinity76@gmail.com on 19 Jun 2012 at 4:23

Attachments:

GoogleCodeExporter commented 9 years ago
patch for wwwsqldesigner.js

had to use an other .patch generator (because googlecode's online generator 
cant add as a comment, only create new "issue", afaik -.-

hopefully compatible, i don't know..

Original comment by divinity76@gmail.com on 19 Jun 2012 at 4:34

Attachments:

GoogleCodeExporter commented 9 years ago
patch for /hg/locale/en.xml

since i only know norwegian/swedish/dannish/english, im not suited to update 
the others..

Original comment by divinity76@gmail.com on 19 Jun 2012 at 4:40

Attachments:

GoogleCodeExporter commented 9 years ago
last notes: 
code based on the AUTO_INCREASE code.
still needs to be ported to the other sql databases that support UNSIGNED types 
(i would be surprised if not all sql databases support it though :p)
still needs to be translated

Original comment by divinity76@gmail.com on 19 Jun 2012 at 4:43

GoogleCodeExporter commented 9 years ago
btw here's live preview
https://divinity76-wwwsqldesigner-testbed.googlecode.com/hg/index.html

Original comment by divinity76@gmail.com on 19 Jun 2012 at 5:06

GoogleCodeExporter commented 9 years ago
I am not sure I want to support this. According to 
http://dev.mysql.com/doc/refman/5.1/en/numeric-type-attributes.html, the 
UNSIGNED attribute is nonstandard and wwwsqldesigner aims to be as DB agnostic 
as possible...

I understand that having an unsigned data type might be reasonable, but I am 
currently not aware of any correct way to implement such feature in 
wwwsqldesigner (you patch adds a checkbox to all, even non-numeric, data 
types...).

Original comment by ondrej.zara on 24 Jun 2012 at 3:38

GoogleCodeExporter commented 9 years ago
ok,i see.
(btw the current auto increment code also put a checkbox to all :p)

for the record, some google'ing, turns out
Supported by:
MySQL
SQLite ( http://www.sqlite.org/lang_createtable.html )

NOT supported by:
CUBRID ( 
http://www.cubrid.org/manual/831/en/Numeric%20Types-Definition%20and%20Character
istics )
MSSQL
Oracle
PostgreSQL

(this was a surprise for me, i believed "signed or not" was a standard thing, i 
was wrong)

Original comment by divinity76@gmail.com on 24 Jun 2012 at 9:50

GoogleCodeExporter commented 9 years ago
According to http://dev.mysql.com/doc/refman/5.1/en/create-table.html, "auto 
increment" is valid for all data types :-)

Original comment by ondrej.zara on 25 Jun 2012 at 8:08