kaplanelad / active-storage

Active Storage facilitates uploading files to a cloud storage
Apache License 2.0
4 stars 2 forks source link

fix: aws s3 config add endpoint url #3

Closed fan-tastic-z closed 10 months ago

fan-tastic-z commented 10 months ago

aws s3 config add endpoint url

kaplanelad commented 10 months ago

Why do you need to override the endpoint_url?

fan-tastic-z commented 10 months ago

Why do you need to override the endpoint_url?

@kaplanelad Did I use it wrong? Where should this endpoint_url be placed?

kaplanelad commented 10 months ago

From how I see it, you want to override the URL endpoint in two use cases

  1. when you have a proxy
  2. for testing I am already doing it here

You can see an example here; I do not see any usage of endpoint override.

Most users will not pass this URL (from what I see). We need to make the initializer clean without many fields. In case the user is advanced and wants to override the endpoint, he can initialize the client and pass it like this example

fan-tastic-z commented 10 months ago

From how I see it, you want to override the URL endpoint in two use cases

  1. when you have a proxy
  2. for testing I am already doing it here

You can see an example here; I do not see any usage of endpoint override.

Most users will not pass this URL (from what I see). We need to make the initializer clean without many fields. In case the user is advanced and wants to override the endpoint, he can initialize the client and pass it like this example

Ok, thanks, I close this pr