simple docker file - Githubissues

kaplanlior / midburn-queue

midburn.org tickets queue system

https://midburn.org

MIT License

2 stars 5 forks source link

Open roeyb opened 8 years ago

roeyb commented 8 years ago

docker build -t midburn/queue .

docker run midburn/queue /bin/sh -c "bundle exec puma -p 9292 -C puma.rb"

eladg commented 8 years ago

Thank you @roeyb !!!

Couple of comments:

MAINTAINER should be an email. maybe will be better to have the Midburn IT email (I think it's it@midburn.org)
How about setting ENTRYPOINT for bundle exec ?
We probably want heroku-docker support + testing (so we can fallback to Heroku). This may work out of the box, but we better try it.
We need to follow: https://devcenter.heroku.com/articles/docker#app-json and include app.json file on the root of the repo.

roeyb commented 8 years ago

@eladg ok, i'm not familiar with heroku enough but i can try next week send me the credentials via slack

eladg commented 8 years ago

The commands to execute are located on the Procfile