search

kaplanlior / midburn-queue

midburn.org tickets queue system
https://midburn.org
MIT License
2 stars 5 forks source link

Removed unreachable banning code. #24

Closed danielkop closed 7 years ago

danielkop commented 8 years ago

As discussed in #21 , @omerpines and @eladg agree that:

  1. "We don't use the ban at all"
  2. "The attacker cannot know the route until we open the queue."

Therefore, this code is unreachable. If It was reachable - this could be a security issue, as an attacker could add other people to the banned list.

yules commented 8 years ago

Hi, thanks a lot. Right now we're on code freeze towards Saturday's sale :)

danielkop commented 8 years ago

Sure, no rush. setting a reminder for sunday

eladg commented 8 years ago

thanks @danielkop, great work!

Post code freeze we will merge all PRs