search

kaplanlior / midburn-queue

midburn.org tickets queue system
https://midburn.org
MIT License
1 stars 5 forks source link

fix params read issue #3

Closed eladg closed 8 years ago

yules commented 8 years ago

How about reading field name ('username') from an application parameter? just like the redirect :)

eladg commented 8 years ago

By saying application parameter, you mean an HTTP parameter? That's exactly what I'm doing here, but notice that Content-Type is JSON which mean that the body of the request is actually a JSON not an HTTP parameter list (the regular index.html?foo=bar&baz=kar)

yules commented 8 years ago

No, i mean which json field to put the user name attribute in. so if we have param USERNAME_FIELD = 'user_name' json should be {user_name: 'yuval@test.com'}

eladg commented 8 years ago

Oh, you mean Environment Variable, great idea! But it has nothing to do with this bugfix / pull request :)

yules commented 8 years ago

you're right :+1: anyway, code is good. merge it, we'll test it towards the OMG sale

eladg commented 8 years ago

@yules: See #4 :)