search

kapouer / node-webkitgtk

webkitgtk bindings for :rocket: Node.js
MIT License
189 stars 13 forks source link

Nan fix #25

Closed gchudnov closed 9 years ago

gchudnov commented 9 years ago

Hi, here I fixed all compilation errors (+1 deprecation warning) for the latest V8 bundled in io.js and Nan v1.7.0.

Please review the changes. I built and run the library, but I'm not an expert in V8, there is a chance I made some mistakes.

Thank you, Grigoriy

kapouer commented 9 years ago

Thank you and almost everything LGTM. I refrained previously from the Size() -> length() fix because afair it a simple replacement couldn't work. Maybe @rvagg could help us on this.

gchudnov commented 9 years ago

hm.. it looks I missed something. Are there any problem with Size -> length?