search

kappa-db / multifeed

Multi-writer hypercore.
135 stars 27 forks source link

fix replication with custom keypairs, and add a test #41

Closed m4gpi closed 4 years ago

m4gpi commented 4 years ago

This fixes a bug introduced in the last keypair pull request, where the previous secret key was being assigned to the next hypercore in opts, causing keys not to match and replication to fail.

ameba23 commented 4 years ago

well done for catching this! @kyphae

hackergrrl commented 4 years ago

Ha, great catch!

On 12/06 01:28, Kieran Gibb wrote:

This fixes a bug introduced in the last keypair pull request, where the previous secret key was being assigned to the next hypercore in opts, causing keys not to match and replication to fail. You can view, comment on, or merge this pull request online at:

https://github.com/kappa-db/multifeed/pull/41

-- Commit Summary --

  • fix replication with custom keypairs, and add a test

-- File Changes --

M index.js (2)
M test/basic.js (53)

-- Patch Links --

https://github.com/kappa-db/multifeed/pull/41.patch https://github.com/kappa-db/multifeed/pull/41.diff

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/kappa-db/multifeed/pull/41

hackergrrl commented 4 years ago

5.1.1

m4gpi commented 4 years ago

:heart: