search

kappa-db / workshop

let's learn how to write peer-to-peer applications in javascript!
https://kappa-db.github.io/workshop
71 stars 26 forks source link

Rewrite highlighting #37

Closed ralphtheninja closed 2 years ago

ralphtheninja commented 2 years ago

Closes #34

Before:

Screenshot from 2022-02-06 18-21-33 Screenshot from 2022-02-06 18-21-58

After:

Screenshot from 2022-02-06 18-20-38 Screenshot from 2022-02-06 18-21-06

hackergrrl commented 2 years ago

Sorry, no capacity to review PRs. 👎🏻

cblgh commented 2 years ago

lgtm i guess :) i'm assuming the pages in build/ that were deleted will be added as part of a deployment or in a separate commit; otherwise i fear the github.io page might not work as expected

ralphtheninja commented 2 years ago

lgtm i guess :) i'm assuming the pages in build/ that were deleted will be added as part of a deployment or in a separate commit; otherwise i fear the github.io page might not work as expected

They weren't deleted, it just looks like it on github, it was just a lot of lines removed. If you expand the diffs you'll see some green in there as well.